Repository navigation
fix: double escaped http-source selectors - #71
Merged
Merged
Conversation
The current JSON contains double escaped http-json source selectors which are not valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current JSON contains double-escaped http-source selectors.
Invalid example (
"id": "google-crawler"):The current file also contains a correct example (
"id": "google-crawler-mobile"):This change fixes invalid selectors in the data.
Validation
I've added a specific validation for this problem. A better validation would be to actually parse the selector expression, but that would need an a dependency and a
package.json. I did not want change the no-dependency principle of the project.