-
-
Notifications
You must be signed in to change notification settings - Fork 151
fix(schema): avoid JSON.stringify crashes on ArkErrors issues slots #1619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ssalbdivad
merged 9 commits into
arktypeio:main
from
gabroberge:fix/arkerrors-tojson-heterogeneous-issues
Jun 30, 2026
+40
−1
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a588463
fix(schema): harden ArkErrors.toJSON for Standard Schema / HTTP seria…
gabroberge 64af601
fix(schema): tighten indexedIssueToJSON for JSON.stringify
gabroberge de27f24
test(schema): harden ArkErrors JSON round-trip regression test
gabroberge f830419
style(schema): format errors regression test
gabroberge dadd88d
test(errors): add tests for Array methods on ArkErrors to ensure corr…
gabroberge fc711bd
refactor(errors): improve documentation and handling of JSON serializ…
gabroberge 906ad09
test(errors): enhance JSON.stringify round-trip test for ArkErrors
gabroberge 52604f1
refactor(errors): remove unused Json type import from errors.ts
gabroberge 42a7a1c
fix(errors): handle optional chaining in validation test
gabroberge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.