Skip to content

Update slugify() default permissive set #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbreker wants to merge 1 commit into
base: qa/2.x
Choose a base branch
from
Open

Update slugify() default permissive set #2378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/model/QubitSlug.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public static function slugify($slug, $creationType = null)
case QubitSlug::SLUG_PERMISSIVE:
if ($isAscii) {
// ASCII allowlist: letters/digits and safe ASCII - _ ~ : ; , = * @; others become "-"
$slug = preg_replace('/[^A-Za-z0-9\-_:;,=\*@~]+/', '-', $slug);
$slug = preg_replace('/[^A-Za-z0-9\-_:,=\*@~]+/', '-', $slug);

break;
}
Expand All @@ -114,7 +114,7 @@ public static function slugify($slug, $creationType = null)
$slug = preg_replace('/\p{Pd}+/u', '-', $slug); // map Pd to "-"

// Allow Unicode letters/digits plus safe ASCII: - _ ~ : ; , = * @
$slug = preg_replace('/[^\p{L}\p{N}\-_:;,=\*@~]+/u', '-', $slug); // property-based allowlist
$slug = preg_replace('/[^\p{L}\p{N}\-_:,=\*@~]+/u', '-', $slug); // property-based allowlist

break;

Expand Down
3 changes: 2 additions & 1 deletion test/phpunit/QubitSlugTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,13 @@ public function providerAll(): array
['test----slug', 'test-slug', 'test-slug'],
['Test Slug', 'test-slug', 'Test-Slug'],
['Test Slug 123', 'test-slug-123', 'Test-Slug-123'],
['Test;Slug', 'test-slug', 'Test-Slug'],

// Apostrophes are removed
["Test 'Slug'", 'test-slug', 'Test-Slug'],

// Allowed safe punctuation in permissive; becomes dashes in restrictive
['a_-~:;,=*@b', 'a-b', 'a_-~:;,=*@b'],
['a_-~:,=*@b', 'a-b', 'a_-~:,=*@b'],

// Accented Latin transliteration vs preservation
['Tést Slug', 'test-slug', 'Tést-Slug'],
Expand Down
Loading