Add automated SPARQL syntax validation for all queries

.github/workflows/test-sparql.yml

@@ -0,0 +1,51 @@
+name: Test SPARQL Files
+
+on:
+  pull_request:
+    branches:
+      - main
+    paths:
+      - 'queries/**.sparql'
+      - 'ical/**.sparql'
+      - 'tests/**'
+      - 'requirements.txt'
+      - '.github/workflows/test-sparql.yml'
+  push:
+    branches:
+      - main
+    paths:
+      - 'queries/**.sparql'
+      - 'ical/**.sparql'
+      - 'tests/**'
+      - 'requirements.txt'
+      - '.github/workflows/test-sparql.yml'
+
+jobs:
+  test:
+    name: Lint SPARQL Files
+    runs-on: ubuntu-latest
+
+    permissions:
+      contents: read
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.12'
+
+      - name: Install dependencies
+        run: |
+          python -m pip install --upgrade pip
+          pip install -r requirements.txt
+
+      - name: Run SPARQL linting tests
+        run: |
+          pytest tests/test_lint_all_sparql_files.py -v
+
+      - name: Run all tests
+        run: |
+          pytest tests/ -v

tests/test_lint_all_sparql_files.py

@@ -0,0 +1,92 @@
+"""Tests to lint all SPARQL files in queries/ and ical/ directories."""
+
+import pytest
+import re
+from pathlib import Path
+from rdflib.plugins.sparql import prepareQuery
+from tests.utils import replace_federated_service_call
+
+
+# Get the project root directory
+PROJECT_ROOT = Path(__file__).parent.parent
+
+# Discover all SPARQL files in queries/ and ical/ directories
+QUERIES_DIR = PROJECT_ROOT / "queries"
+ICAL_DIR = PROJECT_ROOT / "ical"
+
+def get_all_sparql_files():
+    """Get all SPARQL files from queries/ and ical/ directories."""
+    sparql_files = []
+
+    # Get files from queries/ directory
+    if QUERIES_DIR.exists():
+        sparql_files.extend(QUERIES_DIR.glob("*.sparql"))
+
+    # Get files from ical/ directory
+    if ICAL_DIR.exists():
+        sparql_files.extend(ICAL_DIR.glob("*.sparql"))
+
+    return sorted(sparql_files)
+
+
+# Generate test parameters (file path and name for test ID)
+SPARQL_FILES = [(f, f.stem) for f in get_all_sparql_files()]
+
+
+class TestLintAllSPARQLFiles:
+    """Test suite for linting all SPARQL files."""
+
+    @pytest.mark.parametrize("sparql_file,file_name", SPARQL_FILES, ids=[name for _, name in SPARQL_FILES])
+    def test_sparql_file_syntax(self, sparql_file, file_name):
+        """Test that each SPARQL file has valid syntax."""
+        # Read the SPARQL file
+        sparql_text = sparql_file.read_text()
+
+        # Check if file uses RDF-star syntax (not supported by rdflib)
+        # RDF-star uses quoted triples like << ?s ?p ?o >>
+        # Use a more robust pattern to avoid false positives
+        rdf_star_pattern = r'<<\s*\??[\w:]*\s+[^>]+\s*>>'
+        if re.search(rdf_star_pattern, sparql_text):
+            # Basic validation: check that file has basic query structure
+            # Check for query type using word boundaries to avoid matching in strings/comments
+            has_query_type = re.search(r'\b(select|construct|ask|describe)\b', sparql_text, re.IGNORECASE)
+            has_where = re.search(r'\bwhere\b', sparql_text, re.IGNORECASE)
+
+            assert has_query_type, \
+                f"Query from {sparql_file.name} should have a query type (SELECT/CONSTRUCT/ASK/DESCRIBE)"
+            assert has_where, \
+                f"Query from {sparql_file.name} should have a WHERE clause"
+            # Mark as valid since basic structure is correct (RDF-star syntax requires advanced parser)
+            pytest.skip(f"Skipping {sparql_file.name}: uses RDF-star syntax not supported by rdflib")
+            return
+
+        # Replace federated SERVICE call with stub data if present
+        # This is needed because rdflib cannot parse SERVICE calls without network access
+        replacement_text = "VALUES ?stub { <http://example.com/stub> }"
+        stubbed_sparql = replace_federated_service_call(sparql_text, replacement_text)
+
+        # Remove vendor-specific 'from onto:explicit' clause that rdflib doesn't understand
+        stubbed_sparql = stubbed_sparql.replace("from onto:explicit", "")
+
+        # Test that the query parses without errors
+        try:
+            query = prepareQuery(stubbed_sparql)
+            assert query is not None, f"Query from {sparql_file.name} should parse successfully"
+        except Exception as e:
+            pytest.fail(f"Query from {sparql_file.name} failed to parse: {e}")
+
+    def test_all_sparql_files_discovered(self):
+        """Verify that SPARQL files are being discovered from both directories."""
+        sparql_files = get_all_sparql_files()
+
+        # Count files from each directory using parent directory name
+        queries_files = [f for f in sparql_files if f.parent.name == 'queries']
+        ical_files = [f for f in sparql_files if f.parent.name == 'ical']
+
+        assert len(sparql_files) > 0, "Should discover at least one SPARQL file"
+        assert len(queries_files) > 0, "Should discover SPARQL files in queries/ directory"
+        assert len(ical_files) > 0, "Should discover SPARQL files in ical/ directory"
+
+        print(f"\nDiscovered {len(sparql_files)} SPARQL files:")
+        print(f"  - {len(queries_files)} files in queries/")
+        print(f"  - {len(ical_files)} files in ical/")