feat: add HttpExtension SPI for pluggable HTTP endpoints - #15
Open
liudezhi2098 wants to merge 4 commits into
Open
feat: add HttpExtension SPI for pluggable HTTP endpoints#15liudezhi2098 wants to merge 4 commits into
liudezhi2098 wants to merge 4 commits into
Conversation
Introduce HttpExtension interface and HttpEndpoint value object to allow loading custom HTTP endpoints via SPI. Extensions are configured through the httpExtensions server config parameter and loaded at startup by VertxHttpServer via reflection.
- TestVertxHttpServerExtension: 7 tests covering SPI loading, method restriction, invalid path skipping, graceful class-not-found, no-extensions regression, and multi-endpoint registration - TestServerConfiguration: 4 tests for httpExtensions getter/setter, default null, empty array behavior, and chainable setter - VertxHttpServer: minor style fix (expand single-line if blocks)
liudezhi2098
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The HTTP server in BookKeeper does not currently provide a way for external components to register custom HTTP endpoints. This makes it difficult to extend the HTTP API without modifying core code.
Changes
HttpExtensionSPI interface for registering pluggable HTTP endpointsHttpEndpointinterface to describe path, supported methods, and handler serviceVertxHttpServerto load and register extensions viasetHttpExtensionClasses()TestVertxHttpServerExtensionto cover extension registration and routing behavior