Repository navigation
Omit regex flags from emitted patterns - #401
Open
chenxin-yan wants to merge 1 commit into
Open
chenxin-yan wants to merge 1 commit into
chenxin-yan wants to merge 1 commit into
Conversation
RegExp#toString() appends the flags after the closing slash, so a regex with flags such as /u was emitted with the flags inside the pattern. Use RegExp#source instead. Fixes asteasolutions#400.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #400.
A
.regex()check whoseRegExphas flags was emitted with the flags insidepattern, because the pattern came fromRegExp#toString()with only the leading and trailing/stripped./^\p{Lu}+$/ubecame"^\\p{Lu}+$/u", and a client enforcing that pattern rejects every valid value.This uses
RegExp#source, which never includes the delimiters or the flags. Patterns without flags are emitted unchanged, as the existing test covers.Flags that change matching, such as
i,mands, can't be expressed in a JSON Schemapatternand are now omitted rather than emitted as literal text. I've left handling them differently out of scope.Tests: added a spec for a
u-flag regex; the fulljestsuite,test:typesandprettier --checkpass.