Skip to content

ci: bind release-notice inputs via env before shell - #2302

Open
SashaMIT wants to merge 1 commit into
astriaorg:mainfrom
SashaMIT:ci/bind-release-notice-inputs-env
Open

ci: bind release-notice inputs via env before shell#2302
SashaMIT wants to merge 1 commit into
astriaorg:mainfrom
SashaMIT:ci/bind-release-notice-inputs-env

Conversation

@SashaMIT

@SashaMIT SashaMIT commented Aug 5, 2026

Copy link
Copy Markdown

Summary

Bind reusable-workflow inputs.package-name / inputs.display-name into step env: before shell use in the Release Notice step.

Keeps ${{ }} expansions out of the run: script. with: expressions on other steps are unchanged.

Test plan

  • Confirm workflow YAML still validates
  • Optional: re-run a package release-check PR path that emits the notice

Made with Cursor

Move package-name/display-name (and release outputs) into env: before
the Release Notice run script.
@SashaMIT
SashaMIT requested a review from a team as a code owner August 5, 2026 14:03
@SashaMIT
SashaMIT requested a review from joroshiba August 5, 2026 14:03
@github-actions github-actions Bot added the ci issues that are related to ci and github workflows label Aug 5, 2026
@greptile-apps

greptile-apps Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Moves reusable release-workflow inputs and release-version outputs into step environment variables before interpolating them in the shell script, reducing direct GitHub expression expansion inside run:.

  • Binds package name, display name, raw version, and release version through env:.
  • Updates the release-notice script to use quoted shell variable expansions.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable correctness, security, or workflow-contract issues identified.

The changed environment bindings preserve the existing values and the shell script expands each variable within double quotes, maintaining the release notice’s file, title, and message behavior while avoiding direct expression interpolation.

Important Files Changed

Filename Overview
.github/workflows/reusable-release-cargo.yml Safely replaces direct workflow-expression interpolation in the release-notice shell script with environment-variable bindings; no actionable defects identified.

Reviews (1): Last reviewed commit: "ci: bind release-notice inputs via env b..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci issues that are related to ci and github workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant