ci: bind release-notice inputs via env before shell - #2302
Open
SashaMIT wants to merge 1 commit into
Open
Conversation
Move package-name/display-name (and release outputs) into env: before the Release Notice run script.
Contributor
Greptile SummaryMoves reusable release-workflow inputs and release-version outputs into step environment variables before interpolating them in the shell script, reducing direct GitHub expression expansion inside
Confidence Score: 5/5The PR appears safe to merge, with no actionable correctness, security, or workflow-contract issues identified. The changed environment bindings preserve the existing values and the shell script expands each variable within double quotes, maintaining the release notice’s file, title, and message behavior while avoiding direct expression interpolation.
|
| Filename | Overview |
|---|---|
| .github/workflows/reusable-release-cargo.yml | Safely replaces direct workflow-expression interpolation in the release-notice shell script with environment-variable bindings; no actionable defects identified. |
Reviews (1): Last reviewed commit: "ci: bind release-notice inputs via env b..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bind reusable-workflow
inputs.package-name/inputs.display-nameinto stepenv:before shell use in the Release Notice step.Keeps
${{ }}expansions out of therun:script.with:expressions on other steps are unchanged.Test plan
Made with Cursor