Port: enforce IPSIE session_expiry ceiling in credentials managers (#983)#996
Open
pmathew92 wants to merge 1 commit into
Open
Port: enforce IPSIE session_expiry ceiling in credentials managers (#983)#996pmathew92 wants to merge 1 commit into
pmathew92 wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the IPSIE
session_expiryceiling enforcement (originally PR #983 onmain/3.x) onto thev4_developmentbranch, following v4's structure and patterns. The feature reads an upstream-IdP–asserted absolute session ceiling (session_expiry, Unix seconds) from the ID token, pins it at login, and enforces it on every credentials read — clearing credentials and failing withSESSION_EXPIREDonce the ceiling is reached. A refresh token can never extend a session past the ceiling.Public API added
Credentials.sessionExpiresAt: Long?— the enforced ceiling (Unix seconds),nullwhen the connection does not emit the claim.CredentialsManagerException.SESSION_EXPIRED.Behavior
com.auth0.session_expiry), so it survives refreshes whose ID token omits the claim.saveCredentialsrejects an already-expired session up front (validateSessionExpiryAtCreation).getCredentials/getSsoCredentials/getApiCredentials/hasValidCredentialsclear credentials and fail withSESSION_EXPIREDpast the ceiling.