Guard against all uncaught exceptions in the serial executor block#997
Open
pmathew92 wants to merge 1 commit into
Open
Guard against all uncaught exceptions in the serial executor block#997pmathew92 wants to merge 1 commit into
pmathew92 wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| tokenType.orEmpty(), | ||
| refreshToken, | ||
| Date(expiresAt), | ||
| storedScope |
| val expiresAt = fresh.expiresAt.time | ||
| val willAccessTokenExpire = willExpire(expiresAt, minTtl.toLong()) | ||
| if (willAccessTokenExpire) { | ||
| val tokenLifetime = (expiresAt - currentTimeInMillis - minTtl * 1000) / -1000 |
| val expiresAt = newCredentials.expiresAt.time | ||
| val willAccessTokenExpire = willExpire(expiresAt, minTtl.toLong()) | ||
| if (willAccessTokenExpire) { | ||
| val tokenLifetime = (expiresAt - currentTimeInMillis - minTtl * 1000) / -1000 |
| val expiresAt = fresh.expiresAt.time | ||
| val willAccessTokenExpire = willExpire(expiresAt, minTtl.toLong()) | ||
| if (willAccessTokenExpire) { | ||
| val tokenLifetime = (expiresAt - currentTimeInMillis - minTtl * 1000) / -1000 |
| val expiresAt = newCredentials.expiresAt.time | ||
| val willAccessTokenExpire = willExpire(expiresAt, minTtl.toLong()) | ||
| if (willAccessTokenExpire) { | ||
| val tokenLifetime = (expiresAt - currentTimeInMillis - minTtl * 1000) / -1000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the serial-executor exception guard (#970) onto the
v4_developmentbranch as its own feature.runCatchingOnExecutorhelper toBaseCredentialsManager, wrapping eachserialExecutor.execute { }body in acatch (Throwable) -> onFailure(UNKNOWN_ERROR)safety net so unexpected errors surface as a failure callback instead of being swallowed on the executor thread.CredentialsManagerand all 3SecureCredentialsManagerexecute blocks; removes the now-redundant trailingcatch (RuntimeException)blocks while keeping the domain-specific catches (AuthenticationException,CredentialsManagerException,IncompatibleDeviceException,CryptoException).SecureCredentialsManager.continueGetApiCredentialsto parity with the other two blocks by mapping a save failure toSTORE_FAILED(rather than letting it fall through to the newUNKNOWN_ERRORnet).This is the v4 port of the change merged to
mainin #970; reconciled onto v4's restructured credentials managers and test imports (org.mockito.kotlin.*).Test plan
./gradlew :auth0:compileDebugKotlin./gradlew :auth0:testDebugUnitTest— full suite greenCredentialsManagerTest(98 total), 4 new inSecureCredentialsManagerTest(131 total), 0 failures