Repository navigation
fix: detect typedef-aliased arrays and their const qualifier - #97
Merged
Merged
Conversation
xxthunder
force-pushed
the
feat/fix_const_array_mock
branch
from
April 28, 2026 14:30
9b93439 to
015f4ac
Compare
Make is_array check the canonical type so typedef aliases to array types (e.g. typedef uint8 Foo[N]) are correctly recognized. Update is_constant to handle const qualification on typedef arrays. Remove the redundant canonical-type fallback in initializer(). Co-authored-by: Jan Vollmuth <Jan.Vollmuth@marquardt.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
xxthunder
force-pushed
the
feat/fix_const_array_mock
branch
from
April 28, 2026 14:37
015f4ac to
bc67cb1
Compare
Closed
xxthunder
changed the title
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RenderableType.is_array.conston a typedef-to-array variable (const Foo barwheretypedef T Foo[N]), where the qualifier applies to the typedef rather than the element type.Previously,
extern Foo bar;(withtypedef uint8 Foo[4];) was mocked as a scalar and produced an invalid initializer.const Foo bar;was additionally not flagged as constant.Test plan
test_typedef_array— typedef-to-array is detected; initializer is{0}.test_const_typedef_array—conston the typedef is recognized; initializer is{0}.