Skip to content

[Test] Revert the test_slurm_custom_partitions test-only fix #7438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hehe7318 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[Test] Revert the test_slurm_custom_partitions test-only fix #7438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0fc34dc
Revert "Fix test_slurm_custom_partitions intermittent failure by rest…
hehe7318 Jun 10, 2026
5886ccd
Add changelog for the bug fix
hehe7318 Jun 10, 2026
8225b3d
Merge branch 'develop' into wip/revert-fix-custom-patition-test
hehe7318 Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ CHANGELOG
- Fail `pcluster build-image` early when the downloaded cookbook version does not match the ParallelCluster CLI version.
- Fix login nodes not mounting `/opt/parallelcluster/shared` when EFS is used as the internal shared storage type.
- Fix an issue where compute nodes are incorrectly replaced when launching a large number of nodes due to eventual consistency.
- Fix an issue where starting the compute fleet may not reliably recover the cluster from protected mode.

**DEPRECATIONS**
- Amazon Linux 2 is no longer supported.
Expand Down
7 changes: 0 additions & 7 deletions tests/integration-tests/tests/schedulers/test_slurm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,13 +379,6 @@ def test_slurm_custom_partitions(
assert_that(scheduler_commands.get_partition_state(partition=partition)).is_equal_to(expected_state)

logging.info("Checking pcluster start...")
# Restore the protected failure count to its default before starting the fleet. The failing job left dynamic nodes
# still powering up when the fleet was stopped; with a short clustermgtd cleanup window they can survive stop/start
# with a stale nodeaddr. On the first poll after start, clustermgtd re-counts them as bootstrap failures and, with
# the lowered count of 2, re-enters protected mode, flipping the pcluster-managed partitions back to INACTIVE and
# making this test intermittently fail. The default count is high enough that the few leftover nodes cannot reach
# the threshold in a single poll.
set_protected_failure_count(remote_command_executor, 10)
for partition in custom_partitions:
scheduler_commands.set_partition_state(partition, "INACTIVE")
cluster.start()
Expand Down
Loading