[Test] Make the retrieval of flexible instance types more resilient to prevent test failures.#7448
Merged
gmarciani merged 2 commits intoJun 12, 2026
Conversation
In particular: 1. Retry the retrieval to be robust against transient failures (networking glithces or throttling) 2. in case of consistent failure, emit a warning log and fall back to the original instance type. 3. sort the list of equivalent instance types so that multiple calls to the function always returns the same result.
5c4b053 to
13bd11c
Compare
hanwen-cluster
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Make the retrieval of flexible instance types more resilient to prevent test failures.
In particular:
The definitive solution to reduce even more the risk of failures is to cache the result, which is wip in #7402
Tests
SUCCEEDED with cluster config using the expected list of flex instance types. Also checked that every time the test retrieves the list of flex instance type the list is always the same.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.