perf: fix GenericObjectController bypassing controller-runtime cache on every reconcile#211
Open
GnatorX wants to merge 1 commit into
Open
perf: fix GenericObjectController bypassing controller-runtime cache on every reconcile#211GnatorX wants to merge 1 commit into
GnatorX wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
GenericObjectController.Reconcile was calling kubeClient.Get with a *UnstructuredAdapter[T] object. Because UnstructuredAdapter embeds
unstructured.Unstructured, it implements the runtime.Unstructured interface. controller-runtime's cached client checks for this
interface in shouldBypassCache() and, when cacheUnstructured is not explicitly enabled, skips the cache and sends a direct HTTP GET to
the API server.
Since GenericObjectController requeues every 10 seconds, this produced tens of thousands of uncached node (or other resource) GET
requests per minute under normal idle operation — visible in audit logs and a meaningful load on the API server.
This matches the issue reported and fixed in karpenter upstream: kubernetes-sigs/karpenter#3069
Description of changes:
Refactored Controller.reconcile into two internal helpers:
GenericObjectController.Reconcile now:
UnstructuredAdapter
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.