fix(pi-extension): hoist @earendil-works/pi-* runtime deps#984
Open
viadezo1er wants to merge 1 commit into
Open
fix(pi-extension): hoist @earendil-works/pi-* runtime deps#984viadezo1er wants to merge 1 commit into
viadezo1er wants to merge 1 commit into
Conversation
Move @earendil-works/pi-ai, pi-agent-core, and pi-tui from
devDependencies to dependencies so they are installed and hoisted
alongside @plannotator/pi-extension.
These packages are imported at runtime by index.ts (e.g.
`import { Type } from "@earendil-works/pi-ai"`), but were only listed
as devDependencies/peerDependencies. pi installs extensions with
peer-dep resolution disabled (--omit=peer / --legacy-peer-deps), so
on a clean install or `pi update` the modules never land in the
extension's node_modules and pi fails to open with:
Failed to load extension: Cannot find module '@earendil-works/pi-ai'
Require stack:
- @plannotator/pi-extension/index.ts
The namespace was migrated from @mariozechner/* to @earendil-works/*
in backnotprop#729, which swapped the imports and devDependency pins but kept
them as devDependencies — leaving no guaranteed install path for
the runtime imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
@earendil-works/pi-ai,pi-agent-core, andpi-tuifrom devDependencies to dependencies so they are installed and hoisted alongside @plannotator/pi-extension.These packages are imported at runtime by
index.ts(e.g.import { Type } from "@earendil-works/pi-ai"), but were only listed as devDependencies/peerDependencies. pi installs extensions with peer-dep resolution disabled (--omit=peer / --legacy-peer-deps), so on a clean install orpi updatethe modules never land in the extension's node_modules and pi fails to open with:The namespace was migrated from
@mariozechner/*to@earendil-works/*in #729, which swapped the imports and devDependency pins but kept them as devDependencies, leaving no guaranteed install path for the runtime imports.MIT & Apache 2.0 dual-licensing is fine.