Conversation
balena-ci
enabled auto-merge
December 13, 2022 14:19
fisehara
marked this pull request as draft
December 13, 2022 14:37
auto-merge was automatically disabled
December 13, 2022 14:37
Pull request was converted to draft
fisehara
force-pushed
the
record-async-migraiton-execution-time
branch
from
December 14, 2022 15:37
a100f78 to
3e088bd
Compare
fisehara
force-pushed
the
record-async-migraiton-execution-time
branch
from
December 15, 2022 08:33
3e088bd to
6758b37
Compare
fisehara
marked this pull request as ready for review
December 15, 2022 12:23
Page-
reviewed
Dec 15, 2022
Comment on lines
+163
to
+164
| ALTER TABLE "migration status" | ||
| ADD COLUMN IF NOT EXISTS "last execution time ms" INTEGER NULL; |
Contributor
There was a problem hiding this comment.
This would also need to drop the start time column, and that potentially makes it a breaking change
Contributor
Author
There was a problem hiding this comment.
@Page-
I was unsure how to handle it. Basically PineJS doesn't know about old instances that reference the start time. My non favourite solution is to keep the column as is. My preferred solution would be a 2 staged deployment.
Basically it's not breaking the code it's breaking old-still running instances which require start time to be existing.
How was this handled in the past?
Record async migration execution time in migration status table. Add migrationMetricsEmitter to emit metrics Current metrics emitted: - async_migration_status - sync_migration_status Change-type: minor Signed-off-by: fisehara <harald@balena.io>
fisehara
force-pushed
the
record-async-migraiton-execution-time
branch
from
December 20, 2022 20:09
9fd1d70 to
04cded0
Compare
balena-ci
enabled auto-merge
December 20, 2022 20:20
balena-ci
disabled auto-merge
January 12, 2023 17:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record async migration execution time
Record async migration execution time in migration status table.
Add migrationMetricsEmitter to emit metrics
Current metrics emitted:
Change-type: minor
Signed-off-by: fisehara