Function isOrderEncodable should also verify that the order's B value is not zero - #333
Function isOrderEncodable should also verify that the order's B value is not zero#333barakman wants to merge 2 commits into
isOrderEncodable should also verify that the order's B value is not zero#333Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| try { | ||
| encodeOrder(order); | ||
| return true; | ||
| return encodeOrder(order).B > 0n; |
There was a problem hiding this comment.
I believe it is more correct to enforce this inside encodeOrder - and not in isOrderEncodable which is a function that seems to only be used in the tests
There was a problem hiding this comment.
In the SDK of the new carbon version, I have ended up implementing it in a separate function named validOrder.
Other than getting rid of the "toxic" usage of try/catch (can fail for any other unrelated bug or error), it also seems the more correct way to handle order-creation.
In this version of carbon, the conditions are much more simple, and if you decide to adopt the suggestion above, then you'll just need to put your current checks in that function, and then add this check (B > 0) on top.
2 participants
Note
Updates
isOrderEncodableto return true only ifencodeOrder(order).B > 0n, not merely if encoding succeeds.Written by Cursor Bugbot for commit 6b97cc6. This will update automatically on new commits. Configure here.