Repository navigation
Conversation
canShowPasskey now also requires browser WebAuthn support. The Security settings screen hides the Add Passkey button when passkeys are unavailable, and hides the Passkey card entirely unless the user has existing passkeys to remove.
Google and Apple rows show only when the provider is configured (same check as the login screen) or already connected, so a connected provider can still be disabled. The card hides when neither shows. The page error message moves out of the card so passkey errors stay visible.
Passkey, Google and Apple buttons render inside the login form and defaulted to type=submit, so clicking them triggered form validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Security settings page showed passkey, Google and Apple options even when they weren't set up, and clicking the passkey button on the login page made the email and password fields go red. This PR fixes both and turns passkeys on by default.
Changes
Security settings page
Login page
Config
AUTH_PASSKEY=trueinservices/web/.env).Notes for reviewers
AUTH_PASSKEYempty. Setting it tofalsewon't work because any value counts as on.AUTH_PASSKEYis off.