16.0 fix shift attendance - #603
Merged
Merged
Conversation
Appears when an admin try to validate an attendance sheet with their credential. _check_credentials() takes now 2 arguments.
Normal users can not validate an attendance sheet. Their are redirected to a wizard where a member of group_shift_attendance_sheet_validation can enter their credential to validate the wizard. But when a member of group_shift_attendance_sheet_validation view an attendance sheet, they do not see the Feedback’s fields and they do not see the Wizard, so they cannot validate a sheet properly. Except if the validator is member of the shift.gorup_shift_attendance, which is wierd. Member of the group_shift_attendance_sheet_validation can now fill in all the fields required to validate an attendance sheet.
github-grap-bot
added
series:16.0
mod:shift_attendance
remytms
commented
Sep 21, 2026
| .sudo() | ||
| .get_param("shift_attendance.card_support") | ||
| .get_param("shift_attendance.card_support", "False") | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
Use from odoo.tools import str2bool
Bug occurs when the key "shift_attendance.card_support" does not exist because get_param() will return False and it will fail with literal_eval(). If "shift_attendance.card_support" does not exist value should be considered as False.
remytms
force-pushed
the
16.0-fix-shift_attendance
branch
from
September 21, 2026 10:19
a846257 to
a3ea523
Compare
huguesdk
approved these changes
Sep 21, 2026
Collaborator
Author
|
/ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 1b43841. Thanks a lot for contributing to beescoop. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some fixes for shift_attendance.
Odoo task (if applicable)
(task)[https://gestion.coopiteasy.be/web#view_type=form&model=project.task&id=16880&active_id=16880&menu_id=]
Checklist before approval