Omit client_secret for public OAuth clients in token exchange - #13
Open
carlosplanchon wants to merge 1 commit into
Open
Omit client_secret for public OAuth clients in token exchange#13carlosplanchon wants to merge 1 commit into
carlosplanchon wants to merge 1 commit into
Conversation
AbstractOAuthProvider.exchange_code always included client_secret in the token request body. For a public client (PKCE-only, token_endpoint_auth_method=none) client_secret is empty, so the request sent client_secret="", which several IdPs reject since a public client must not send client authentication. Include the field only when it is set; the PKCE code_verifier, sent either way, is the public client's proof. Confidential clients are unchanged. Adds test_token_exchange.py capturing the token POST body for both the confidential and public modes. Signed-off-by: Carlos Andrés Planchón Prestes <carlosandresplanchonprestes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exchange_code always sent client_secret; for a public client (PKCE-only, token_endpoint_auth_method=none) that means sending client_secret="", which several IdPs reject. Now included only when set. PKCE is the public client's proof and is sent either way. Confidential clients unchanged; tests cover both modes. Found while integrating a self-hosted OIDC provider (Zitadel).