Skip to content

Overload connect function to accept binary host #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benoitc merged 2 commits into from
Jul 14, 2026
+4 −1
Merged

Overload connect function to accept binary host #906

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24bbf44
Overload connect function to accept binary host
TBK145 Jul 13, 2026
08a0393
Merge connect/4 clauses under one spec so it compiles
benoitc Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/hackney.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,10 @@ connect(URL, Options) when is_binary(URL) orelse is_list(URL) ->
connect(Transport, Host, Port) ->
connect(Transport, Host, Port, []).

-spec connect(module(), string(), inet:port_number(), list()) -> {ok, conn()} | {error, term()}.
-spec connect(module(), string() | binary(), inet:port_number(), list()) ->
{ok, conn()} | {error, term()}.
connect(Transport, Host, Port, Options) when is_binary(Host) ->
connect(Transport, binary_to_list(Host), Port, Options);
connect(Transport, Host, Port, Options) ->
%% Check if using a pool
UsePool = use_pool(Options),
Expand Down
Loading