Stop non-reusable connections when a request completes#908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #902.
When a synchronous request finished, hackney always returned the connection to
connected, without checking whether it could be reused. A connection flaggedno_reuse(proxy tunnel, SSL upgrade, pool disabled) or answered withConnection: closethen stayed parked inconnected. With a long lived owner nothing ever stopped it, so onehackney_connprocess leaked per request until the node ran out of memory. The async path already handled this, the sync path did not.The reuse decision is now a single predicate,
connection_reusable/1, used by both the sync and the async completion. A reusable connection returns toconnected(a pooled one goes back to the pool, a direct one stays for the owner to reuse), a non-reusable one is closed and its process stopped.This also fixes a matching gap on the async side: a
no_reusepooled connection used to return toconnectedinstead of stopping, because the async decision looked atConnection: closebut not atno_reuse. Both paths now share the same rule.Keep-alive reuse is unchanged.