fix: apply timeout to mounted ASGI apps (#5246)#5621
Open
Anya-Gupta-05 wants to merge 2 commits into
Open
Conversation
TimeoutMiddleware was applied to native @bentoml.api routes but not to apps mounted via @bentoml.asgi_app / mount_asgi_app. Wrap each mount_app with TimeoutMiddleware when timeout is set.
For more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5246
Problem
traffic={"timeout": N}was applied to native BentoML API routesbut ignored for apps mounted via
@bentoml.asgi_app. Mounted routesran under the default 60s timeout regardless of config.
Fix
Wrap each mounted app with
TimeoutMiddlewareat mount time inServiceAppFactory.__call__, using the existingself.timeoutvalue from the base class.
Test
Start service with
traffic={"timeout": 10}, hit a mounted FastAPIroute that sleeps 15s — now returns 504 after 10s.