feat: add native pylock.toml support for container dependency resolution#5634
Open
TemidayoA wants to merge 2 commits into
Open
feat: add native pylock.toml support for container dependency resolution#5634TemidayoA wants to merge 2 commits into
TemidayoA wants to merge 2 commits into
Conversation
For more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR address?
Fixes #5466
This PR introduces native support for
pylock.tomlin the Bento containerization build process, allowing users to strictly lock down and resolve Python dependencies usinguv(bypassing current limitations withrequirements.txtextra-index-urls).Implementation Details:
build_config.py): Addedpylock_tomlto thePythonOptionsschema and implemented the file copy logic to stage the lockfile in theenv/python/build context.generate.py): Injected a_has_pylockboolean flag into the Jinja templating context by evaluating the existence of the staged lockfile.base.j2): Updated the base Dockerfile template to conditionally executeuv pip sync /home/bentoml/bento/env/python/pylock.tomlwhen_has_pylockis true, safely falling back to the standardinstall.shpipeline if no lockfile is present.This ensures that deployments requiring complex or isolated package indexes can rely entirely on standard lockfiles during the Docker build step without breaking existing backwards compatibility.