Skip to content

feat(consensus): Implement and wire halt-height and halt-time - #3147

Merged
fridrik01 merged 5 commits into
mainfrom
fix-halt-height
Jul 21, 2026
Merged

feat(consensus): Implement and wire halt-height and halt-time#3147
fridrik01 merged 5 commits into
mainfrom
fix-halt-height

Address PR comments

8e93d5f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 21, 2026 in 0s

63.07% (target 0.00%)

View this Pull Request on Codecov

63.07% (target 0.00%)

Details

Codecov Report

❌ Patch coverage is 70.00000% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.07%. Comparing base (c6af391) to head (8e93d5f).

Files with missing lines Patch % Lines
consensus/cometbft/service/service.go 45.00% 11 Missing ⚠️
consensus/cometbft/service/commit.go 73.52% 8 Missing and 1 partial ⚠️
consensus/cometbft/service/options.go 60.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3147      +/-   ##
==========================================
+ Coverage   63.04%   63.07%   +0.02%     
==========================================
  Files         371      371              
  Lines       15461    15533      +72     
==========================================
+ Hits         9748     9798      +50     
- Misses       4757     4777      +20     
- Partials      956      958       +2     
Files with missing lines Coverage Δ
consensus/cometbft/service/abci.go 35.00% <100.00%> (+9.28%) ⬆️
consensus/cometbft/service/finalize_block.go 46.20% <100.00%> (+0.75%) ⬆️
node-core/builder/baseapp_options.go 63.04% <100.00%> (+1.67%) ⬆️
consensus/cometbft/service/options.go 62.85% <60.00%> (-1.15%) ⬇️
consensus/cometbft/service/commit.go 52.17% <73.52%> (+15.58%) ⬆️
consensus/cometbft/service/service.go 38.41% <45.00%> (+0.83%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.