Skip to content

Apply template exclusions when combining schemas - #334

Merged
ypriverol merged 2 commits into
devfrom
copilot/fix-metaproteomics-exclusions
Aug 27, 2026
Merged

Apply template exclusions when combining schemas#334
ypriverol merged 2 commits into
devfrom
copilot/fix-metaproteomics-exclusions

Conversation

Copilot AI commented Aug 6, 2026

Copy link
Copy Markdown

When combining multiple templates (e.g., ms-proteomics + metaproteomics), exclusions declared by any template were ignored. The metaproteomics template explicitly excludes sample-metadata, but columns from that excluded template were still required when combined with ms-proteomics.

Changes

  • Model Updates: Added excludes field to SchemaDefinition to represent template exclusions from YAML
  • Exclusion Resolution: Implemented _get_excluded_templates() to collect all excluded templates from schemas being combined
  • Column Filtering: Added _get_template_columns() to recursively identify columns defined by a template (including inherited columns)
  • Schema Combination: Modified combine_schemas() to filter out columns belonging to excluded templates before returning the combined schema

Example exclusion in YAML:

name: metaproteomics
excludes:
  templates:
    - sample-metadata

When combine_schemas(['ms-proteomics', 'metaproteomics']) is called, columns from sample-metadata (such as characteristics[organism], characteristics[organism part]) are now properly excluded from the combined schema.

Co-authored-by: ypriverol <52113+ypriverol@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix metaproteomics exclusions in validator Apply template exclusions when combining schemas Aug 6, 2026
Copilot AI requested a review from ypriverol August 6, 2026 09:50
@ypriverol
ypriverol marked this pull request as ready for review August 27, 2026 08:06
@qodo-code-review

Copy link
Copy Markdown
Contributor

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@ypriverol
ypriverol merged commit 8ca630f into dev Aug 27, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Metaproteomics exclusions are ignored when combining templates

2 participants