Add a tags Proxy to Crank Core - #392
Open
zakarialaoui10 wants to merge 4 commits into
Open
zakarialaoui10 wants to merge 4 commits into
zakarialaoui10 wants to merge 4 commits into
Conversation
brainkim
requested changes
Sep 29, 2026
brainkim
left a comment
brainkim
left a comment
Member
There was a problem hiding this comment.
@zakarialaoui10 Thank you for the PR and sorry for taking so long I’ve been busy with some other work. Also sorry for the random Claude spam.
I left some review. This PR isn’t likely to be merged without some tests.
I can work on this eventually if you wish. Let me know if you have any questions.
| * function that forwards its arguments to `createElement`. | ||
| */ | ||
| export const tags = new Proxy( | ||
| {} as Record< |
Member
There was a problem hiding this comment.
Should use Object.create(null) as using an empty object will carry a bunch of object cruft.
Use a null-prototype object for the dynamic tag cache and ignore symbol properties and then to avoid prototype collisions
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.