Skip to content

fix: support native file dragging from local filesystem panes - #3377

Merged
binaricat merged 2 commits into
binaricat:mainfrom
nervi0s:local-native-file-drag
Sep 18, 2026
Merged

binaricat merged 2 commits into
binaricat:mainfrom
nervi0s:local-native-file-drag

Conversation

@nervi0s

@nervi0s nervi0s commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Dragging local files from Netcatty currently exposes a text payload, which can create .textClipping files in Finder instead of transferring the actual files.

This change uses Electron native file dragging for local filesystem panes while preserving the existing remote SFTP drag path.

Type of Change

  • Bug fix
  • New feature
  • Refactor / code cleanup
  • Documentation update
  • Build / CI change
  • Other (please describe):

Related Issue (optional)

N/A

Changes Made

  • Enable native dragging only when the source connection has isLocal === true.
  • Support single and multiple files and folders in both panes, in list and tree views.
  • Validate IPC senders and filesystem paths before starting the native drag.
  • Route matching internal drops through existing copy and move callbacks.
  • Preserve remote SFTP dragging and transfer services.
  • Add regression tests, an interactive Electron fixture, and validation documentation.
  • No new dependencies or temporary file copies.

Screenshots / Demo

Local drag now provides native filesystem paths instead of plain-text filenames. Mac OS, Windows 11 and Linux desktop checks were completed successfully.

Testing

  • I have tested these changes locally (npm run dev)
  • Linting passes (npm run lint)
  • Tests pass (npm test)
  • Generated capability tool specs are updated when applicable (npm run generate:capability-tools)
  • No new console errors or warnings, if this affects app behavior

Test notes:

  • Full suite: 11,665 passed, 28 skipped with LC_ALL=C.UTF-8.
  • Eight Spanish-locale server-stats failures reproduce on both unmodified HEAD and this branch.
  • Two interactive-zsh failures were reported in another run; targeted reruns passed and their cause remains unconfirmed.
  • Windows 11 and Linux desktop checks passed in contributor testing.
  • See docs/local-file-drag-validation.md for details.

Checklist

  • My code follows the existing project style
  • I have added or updated relevant documentation
  • I have not introduced any breaking changes (or I have described them above)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 62a2a05f37

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread electron/bridges/localFileDragBridge.cjs Outdated
@binaricat

Copy link
Copy Markdown
Owner

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-09-13T09:05:42.538648Z 6562dd5 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@nervi0s

nervi0s commented Sep 13, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 6562dd5871

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@binaricat
binaricat merged commit ec2f0d0 into binaricat:main Sep 18, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants