fix: support native file dragging from local filesystem panes - #3377
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62a2a05f37
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Summary
Dragging local files from Netcatty currently exposes a text payload, which can create .textClipping files in Finder instead of transferring the actual files.
This change uses Electron native file dragging for local filesystem panes while preserving the existing remote SFTP drag path.
Type of Change
Related Issue (optional)
N/A
Changes Made
Screenshots / Demo
Local drag now provides native filesystem paths instead of plain-text filenames. Mac OS, Windows 11 and Linux desktop checks were completed successfully.
Testing
npm run dev)npm run lint)npm test)npm run generate:capability-tools)Test notes:
LC_ALL=C.UTF-8.docs/local-file-drag-validation.mdfor details.Checklist