feat: add benchmark manifest, failure logs, and shellcheck CI - #5
Merged
Merged
Conversation
Add benchmark run manifest metadata, preserve test logs on failures, and introduce a shellcheck workflow to catch shell regressions early. Also allow agent CLI binaries to be overridden via environment variables for easier cross-environment setup. Fixes #1 Fixes #2 Fixes #3 Fixes #4 Co-authored-by: Cursor <cursoragent@cursor.com>
Validate AGENT_*_BIN values with a safe character policy and remove eval-based version execution to prevent shell injection and parsing regressions. Also document that overrides must be a single executable path. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manifest.jsongeneration for each benchmark run with run metadata and agent versionstest.logonly when problem tests fail, and print log path in benchmark outputTest plan
for f in $(rg --files -g '*.sh'); do bash -n "$f" || exit 1; donebenchmark/benchmark.sh --help >/dev/nullbenchmark/benchmark.sh --agents codex --suite fizzbuzzin a configured environment and confirmmanifest.jsonis generatedtest.logis preserved and path is printedCloses #1
Closes #2
Closes #3
Closes #4
Made with Cursor