bugfix: Close transaction detail windows when switching wallets#941
Open
pablomartin4btc wants to merge 2 commits into
Open
bugfix: Close transaction detail windows when switching wallets#941pablomartin4btc wants to merge 2 commits into
pablomartin4btc wants to merge 2 commits into
Conversation
Add WalletView::closeTransactionDialogs() which delegates to TransactionView::closeOpenedDialogs(). Call it from WalletFrame::setCurrentWallet() when hiding the outgoing wallet view, so any open TransactionDescDialog windows from the previous wallet are closed before the view is hidden.
…witch Add TestCloseTransactionDialogs() which selects a transaction, opens its detail dialog via showDetails(), then calls closeOpenedDialogs() and verifies the dialog is gone. Exercises the path triggered by WalletView::closeTransactionDialogs() during a wallet switch.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. |
Contributor
Author
|
-Updates:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user switches to a different wallet, any open transaction detail windows (
TransactionDescDialog) from the previous wallet's view remain visible. The dialogs are backed by the outgoing wallet's data but stay on screen, which is confusing.Fix by adding
WalletView::closeTransactionDialogs()(delegating to the existingTransactionView::closeOpenedDialogs()) and calling it fromWalletFrame::setCurrentWallet()when hiding the outgoing view.A Qt test was added to verify that open transaction detail dialogs are closed when
closeOpenedDialogs()is called.Possible follow-up: remembering which transaction detail windows were open per wallet and restore them when switching back to that wallet.