Skip to content

Add SECURITY.md - #2243

Merged
murchandamus merged 1 commit into
bitcoin:masterfrom
jonatack:2026-08-add-security_md-document
Aug 17, 2026
Merged

Add SECURITY.md#2243
murchandamus merged 1 commit into
bitcoin:masterfrom
jonatack:2026-08-add-security_md-document

Conversation

@jonatack

@jonatack jonatack commented Aug 8, 2026

Copy link
Copy Markdown
Member

This information is already in BIPs 2 and 3, but ISTM that an explicit SECURITY file would conform to current best practice.

I did not include a section about gpg keys to communicate sensitive information; if wanted, it could be added here or later.

@murchandamus

murchandamus commented Aug 8, 2026

Copy link
Copy Markdown
Member

I’m not sure I understand the motivation here. Since we don’t ship a software project, what responsible disclosures could we possibly get?

@jonatack

jonatack commented Aug 8, 2026

Copy link
Copy Markdown
Member Author

No strong opinion but idea is, what if an issue is found in a specification (or its example implementation) here that could lead to a potential vulnerability/exploit in an implementation.

@ajtowns

ajtowns commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

I would think that for a deployed standard, contacting the implementations directly initially would be wise, then adding a "this spec should not be implemented" warning until full disclosure is reasonable. I don't think adding the BIP editors as middlemen for contacting implementations is likely to help anyone out -- half the time it seems like BIP editors have a hard enough job getting into contact with BIP authors as it is even when there's not some looming disaster...

@jonatack

jonatack commented Aug 9, 2026

Copy link
Copy Markdown
Member Author

for a deployed standard, contacting the implementations directly initially would be wise

Yes. It might be worthwhile to state this here.

then adding a "this spec should not be implemented" warning until full disclosure is reasonable

The red team or the implementation would need to contact us privately, so having the contact emails easily findable like here seems useful.

@jonatack jonatack added the Process Trying to update process or stuck due to disagreement about Process label Aug 9, 2026
@ajtowns

ajtowns commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

then adding a "this spec should not be implemented" warning until full disclosure is reasonable

The red team or the implementation would need to contact us privately, so having the contact emails easily findable like here seems useful.

If your goal is to publicly update a spec to recommend everyone stop using it, then I don't think there's anything that needs to be done in private. Probably having one of the (co-)authors open a PR with the extra text and merging it as soon as it's verified it's not an impersonator is the ideal outcome. If the authors aren't in the loop, I think marking a BIP as having security issues wouldn't actually comply with BIP 3 processes anyway?

@edilmedeiros

Copy link
Copy Markdown
Contributor

I believe IETF has a reasonable advisor and process.

tldr:

While the preferred approach to reporting IETF protocol vulnerabilities is to contact the person or group responsible for the document, as a last resort, reports can always be sent by email to protocol-vulnerability@ietf.org. The IETF Security Area Directors will make their best effort to triage the report.

I believe having a single email for security reports is considered a best practice instead of many individual emails. Never understood it completely because that single email distributor can be compromised.

Comment thread SECURITY.md Outdated
Comment thread SECURITY.md Outdated
@jonatack
jonatack force-pushed the 2026-08-add-security_md-document branch 3 times, most recently from aefec49 to 27667bc Compare August 13, 2026 16:31
@jonatack

Copy link
Copy Markdown
Member Author

Updated with your feedback @ajtowns @edilmedeiros @murchandamus (thanks!)

@edilmedeiros I wanted to add you as co-author but I don't have your git-related email yet.

@murchandamus

murchandamus commented Aug 13, 2026

Copy link
Copy Markdown
Member

I think it’s jose.edil@gmail.com per a recent commit of his. Maybe you can put it in already and @edilmedeiros can confirm.

(Did you know that you can look at a commit directly by adding .patch to the URL of a commit?)

image image image

@jonatack
jonatack force-pushed the 2026-08-add-security_md-document branch from 27667bc to 335c4ba Compare August 13, 2026 18:03
Co-authored-by: Murch <murch@murch.one>
Co-authored-by: Anthony Towns <aj@erisian.com.au>
Co-authored-by: Edil Medeiros <jose.edil@gmail.com>
@jonatack
jonatack force-pushed the 2026-08-add-security_md-document branch from 335c4ba to d8cb214 Compare August 13, 2026 18:04
@jonatack

Copy link
Copy Markdown
Member Author

Updated, thanks! TIL.

@murchandamus murchandamus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should include our GPG keys, so emails can be encrypted?

@edilmedeiros

Copy link
Copy Markdown
Contributor

I think it’s jose.edil@gmail.com per a recent commit of his.

Yes, this email. Thanks.

@murchandamus
murchandamus merged commit 857a7de into bitcoin:master Aug 17, 2026
4 checks passed
@jonatack
jonatack deleted the 2026-08-add-security_md-document branch August 17, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Process Trying to update process or stuck due to disagreement about Process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants