Skip to content

fix(android): prevent Node top bar title from clipping - #877

Open
codesbyjit wants to merge 1 commit into
bitcoinppl:masterfrom
codesbyjit:fix/android-node-top-bar-title-clipping-876
Open

codesbyjit wants to merge 1 commit into
bitcoinppl:masterfrom
codesbyjit:fix/android-node-top-bar-title-clipping-876

Conversation

@codesbyjit

Copy link
Copy Markdown

Summary

Fixes #876

The Android Node settings screen constrained SettingsTopAppBar to a fixed 56.dp height, which caused the Node title to be vertically clipped.

Fix

Removed the fixed Modifier.height(56.dp) constraint, allowing the top app bar to use its normal layout and display the title correctly.

Before

2026-08-30-141036_hyprshot

After

2026-08-30-153927_hyprshot

Testing

  • Built and launched the Android app successfully.
  • Verified the Node title is fully visible.
  • Verified navigation away from and back to the Node settings screen.
  • Verified the issue no longer occurs after restarting the app.

Platform Coverage

  • Tested on Android simulator

Checklist

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: fa7c7ead-566b-4df6-ab1e-25dbf87c0721

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Aug 30, 2026

Copy link
Copy Markdown

Greptile Summary

Removes the fixed 56.dp height from the Android Node settings top bar so Material3 can use its normal layout and render the title without clipping.

  • Restores the default SettingsTopAppBar sizing behavior.
  • Leaves navigation, actions, and screen content unchanged.

Confidence Score: 5/5

The PR appears safe to merge with no actionable regressions identified.

The change only removes an undersized explicit height and allows the existing Material3 top bar to use its standard sizing within the established settings-screen layout.

Important Files Changed

Filename Overview
android/app/src/main/java/org/bitcoinppl/cove/flows/SettingsFlow/NodeSettingsScreen.kt Removes the undersized top-bar height constraint; the resulting layout matches the established pattern used by most sibling settings screens.

Reviews (1): Last reviewed commit: "fix(android): prevent Node top bar title..." | Re-trigger Greptile

@praveenperera
praveenperera force-pushed the fix/android-node-top-bar-title-clipping-876 branch from 0d4c9d0 to afa05fc Compare September 7, 2026 16:15
@praveenperera

Copy link
Copy Markdown
Member

thanks @codesbyjit approved

@praveenperera
praveenperera enabled auto-merge (squash) September 7, 2026 16:16
@praveenperera
praveenperera force-pushed the fix/android-node-top-bar-title-clipping-876 branch from afa05fc to 592a005 Compare September 18, 2026 12:39
@praveenperera
praveenperera enabled auto-merge (squash) September 18, 2026 12:39
@praveenperera praveenperera added the review-complete Review complete, ready to merge label Sep 18, 2026
@praveenperera
praveenperera force-pushed the fix/android-node-top-bar-title-clipping-876 branch from 592a005 to 6897477 Compare September 18, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-complete Review complete, ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android: Node settings screen top bar title is clipped

2 participants