build(xtask): respect custom cargo target directories - #881
RandyMcMillan wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: bitcoinppl/cove/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
#881 and #882 tested with Xcode config https://github.com/RandyMcMillan/cove/tree/1849/967481/819159/0496e95f/4b0a2414-upstream-pr |
praveenperera
left a comment
There was a problem hiding this comment.
Thanks @RandyMcMillan approved
23235a8 to
b1a9618
Compare
|
@RandyMcMillan can you please run cargo fmt on the latest rust |
b1a9618 to
d842e71
Compare
Head branch was pushed to by a user without write access
d842e71 to
21e9a18
Compare
Query cargo metadata to obtain the actual target directory instead of hardcoding ./target/. This fixes builds for users with CARGO_TARGET_DIR or [build] target-dir set in their cargo config. chore(apply cargo fmt): rust/xtask/src/common.rs chore(apply cargo fmt): rust/xtask/src/android.rs
21e9a18 to
9886f4e
Compare
done 9886f4e |
No description provided.