PM-31118: feat: Add support for SDK pin unlock

[david-livefront]

🎟️ Tracking

PM-31118

📔 Objective

This PR add support for SDK pin unlock.

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: REQUEST CHANGES

This PR gates PIN unlock behind a new SdkPinUnlock feature flag, routing unlock through InitUserCryptoMethod.PinState when enabled and restructuring the legacy-key/envelope fallback in VaultRepositoryImpl.unlockVaultWithPin. The flag plumbing (FlagKey, debug menu list item, non-localized string, DI wiring) is complete and consistent with existing flags. The main gap is on the test side: the new required featureFlagManager constructor parameter is not reflected in VaultRepositoryTest, which breaks compilation of the :app test source set and leaves the new flag branch uncovered.

Code Review Details

• ❌ : New required featureFlagManager constructor parameter breaks :app test compilation; existing PIN tests still assert envelope-first ordering and the new SdkPinUnlock branch is untested
  • app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt:87
  • app/src/test/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt:122
• ❓ : Legacy pin-protected user key now takes precedence over the envelope even when the flag is off — intentional?
  • app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt:381

[codecov]

Codecov Report

❌ Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.35%. Comparing base (d817f6b) to head (948beac).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...arden/data/vault/repository/VaultRepositoryImpl.kt	90.47%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7289   +/-   ##
=======================================
  Coverage   86.35%   86.35%           
=======================================
  Files         893      893           
  Lines       65488    65496    +8     
  Branches     9861     9863    +2     
=======================================
+ Hits        56550    56557    +7     
  Misses       5464     5464           
- Partials     3474     3475    +1     

Flag	Coverage Δ
app-data	17.90% <90.47%> (+<0.01%)	⬆️
app-ui-auth-tools	18.96% <0.00%> (-0.01%)	⬇️
app-ui-platform	16.37% <0.00%> (-0.01%)	⬇️
app-ui-vault	27.29% <0.00%> (-0.01%)	⬇️
authenticator	6.09% <0.00%> (-0.01%)	⬇️
lib-core-network-bridge	4.09% <0.00%> (+0.01%)	⬆️
lib-data-ui	1.20% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[david-livefront]

With this new init method, the SDK will retrieve the pinProtectedUserKeyEnvelope using the SdkStateBridge.

[andrebispo5]

⛏️ 💭 A few of these tests call prepareStateForUnlocking() and then immediately null out the keys it just seeded. Could the helper take pinProtectedUserKey and pinProtectedUserKeyEnvelope params (defaulting to "mockKey-1") so each test just passes null for the one it wants missing? Would trim the setup blocks a bit and quiet the storePinProtectedUserKey deprecation warnings.

[andrebispo5]

👌

[david-livefront]

Thanks @andrebispo5