OTWO-7717 Open redirect via referer header redirect_back uses allow_o… - #1936
Open
Niharika1117 wants to merge 2 commits into
Open
OTWO-7717 Open redirect via referer header redirect_back uses allow_o…#1936Niharika1117 wants to merge 2 commits into
Niharika1117 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens controller redirection logic to prevent open redirects via the Referer header by disallowing cross-host redirect_back targets, and adds regression tests to cover the behavior.
Changes:
- Set
allow_other_host: falseonredirect_backusages inProjectsControllerandOrgFilters. - Force
redirect_to_saved_pathto disallow cross-host redirects. - Add controller tests asserting external-Referer redirects fall back to safe internal locations.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/controllers/projects_controller_test.rb | Adds regression tests for safe redirect_back behavior in report_outdated. |
| test/controllers/organizations_controller_test.rb | Adds regression test ensuring unauthorized flow doesn’t redirect to external Referer. |
| test/controllers/application_controller_test.rb | Adds tests for redirect_to_saved_path redirect safety (and a test-only route/action). |
| app/controllers/projects_controller.rb | Disallows cross-host redirects when redirecting back from report_outdated. |
| app/controllers/concerns/org_filters.rb | Disallows cross-host redirects in the unauthorized org edit flow. |
| app/controllers/application_controller.rb | Forces redirect_to_saved_path to disallow cross-host redirects. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ther_host: true