Skip to content

OTWO-7729 Project id and enlistment id relationship not validated in … - #1937

Open
Niharika1117 wants to merge 1 commit into
stagingfrom
OTWO-7729
Open

OTWO-7729 Project id and enlistment id relationship not validated in …#1937
Niharika1117 wants to merge 1 commit into
stagingfrom
OTWO-7729

Conversation

@Niharika1117

Copy link
Copy Markdown
Contributor

…enlistment API

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an enlistment API integrity issue by ensuring the project_id in the route is actually used to scope the enlistment lookup, preventing cross-project access to enlistments by ID.

Changes:

  • Scope enlistment lookup to @project.enlistments so an enlistment from another project returns 404.
  • Add a controller test verifying show returns 404 when the enlistment belongs to a different project.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
app/controllers/concerns/enlistment_filters.rb Scopes find_enlistment to the current project to enforce the project/enlistment relationship.
test/controllers/enlistments_controller_test.rb Adds regression coverage for the 404 behavior when project/enlistment mismatch occurs.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants