OTWO-7729 Project id and enlistment id relationship not validated in … - #1937
Open
Niharika1117 wants to merge 1 commit into
Open
OTWO-7729 Project id and enlistment id relationship not validated in …#1937Niharika1117 wants to merge 1 commit into
Niharika1117 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes an enlistment API integrity issue by ensuring the project_id in the route is actually used to scope the enlistment lookup, preventing cross-project access to enlistments by ID.
Changes:
- Scope enlistment lookup to
@project.enlistmentsso an enlistment from another project returns 404. - Add a controller test verifying
showreturns 404 when the enlistment belongs to a different project.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
app/controllers/concerns/enlistment_filters.rb |
Scopes find_enlistment to the current project to enforce the project/enlistment relationship. |
test/controllers/enlistments_controller_test.rb |
Adds regression coverage for the 404 behavior when project/enlistment mismatch occurs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…enlistment API