Skip to content

OTWO-7705 Username enumeration via activation resend endpoint — disti… #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Niharika1117 wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

OTWO-7705 Username enumeration via activation resend endpoint — disti… #1938

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
232a327
OTWO-7705 Username enumeration via activation resend endpoint — disti…
Niharika1117 Aug 11, 2026
08d3c5a
review changes
Niharika1117 Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/controllers/activation_resends_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ def find_account_by_email
@account = Account.find_by(email: params[:email])
return unless @account.nil?

@errors = t('.no_account')
render :new
redirect_to root_path, notice: t('.success')
end
Comment thread
Niharika1117 marked this conversation as resolved.
end
10 changes: 5 additions & 5 deletions test/controllers/activation_resends_controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ class ActivationResendsControllerTest < ActionController::TestCase
_(flash[:success]).must_equal I18n.t('activation_resends.create.recently_activated')
end

it 'Should not allow if email is invalid' do
it 'should not send email if account does not exist' do
before = ActionMailer::Base.deliveries.count
post :create, params: { email: 'InvalidEmail' }
post :create, params: { email: 'nonexistent@example.com' }
_(ActionMailer::Base.deliveries.count).must_equal before
assert_response :ok
assert_template :new
_(assigns(:errors)).must_equal I18n.t('activation_resends.create.no_account')
assert_response :redirect
assert_redirected_to root_path
_(flash[:notice]).must_equal I18n.t('activation_resends.create.success')
end

it 'should resend activation mail' do
Expand Down
Loading