OTWO-7713 CWE-1021: Clickjacking — X-Frame-Options and CSP frame-ance… - #1942
Open
Niharika1117 wants to merge 2 commits into
Open
OTWO-7713 CWE-1021: Clickjacking — X-Frame-Options and CSP frame-ance…#1942Niharika1117 wants to merge 2 commits into
Niharika1117 wants to merge 2 commits into
Conversation
…stors headers missing, login page embeds in external iframe
There was a problem hiding this comment.
Pull request overview
Adds clickjacking protections for authentication/session and account-related endpoints by ensuring frame-embedding is restricted via X-Frame-Options and CSP frame-ancestors.
Changes:
- Adds a Rails initializer that patches
Clearance::SessionsControllerto apply clickjacking headers on/sessions/newandDELETE /sessions. - Adds an
after_actiononAccountsControllerto apply the same clickjacking headers to account pages.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| config/initializers/clearance_session_security.rb | Hooks into Clearance::SessionsController to set XFO + CSP frame-ancestors for session endpoints that bypass the app’s controller subclass. |
| app/controllers/accounts_controller.rb | Adds an after_action and helper method to apply the same anti-clickjacking headers to account pages. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…stors headers missing, login page embeds in external iframe