OTWO-7714 CWE-1104: Bootstrap 3.2.0 in use — XSS CVEs (CVE-2018-14041… - #1946
Open
Niharika1117 wants to merge 2 commits into
Open
OTWO-7714 CWE-1104: Bootstrap 3.2.0 in use — XSS CVEs (CVE-2018-14041…#1946Niharika1117 wants to merge 2 commits into
Niharika1117 wants to merge 2 commits into
Conversation
…CVE-2018-14042, CVE-2019-8331) unpatched; bundle-audit non-blocking in CI
There was a problem hiding this comment.
Pull request overview
This PR updates the frontend Bootstrap JavaScript to address known XSS-related CVEs affecting Bootstrap 3.2.0, and adjusts the asset manifest and CI behavior accordingly.
Changes:
- Vendor Bootstrap JavaScript updated to Bootstrap v3.4.1 (
bootstrap.min.js) to pick up security fixes. - Asset pipeline manifest switched from
twitter/bootstrapto the vendoredbootstrap.min. - CI workflow’s bundle-audit step behavior changed by removing
continue-on-error.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
vendor/assets/javascripts/bootstrap.min.js |
Replaces the Bootstrap JS runtime with v3.4.1 (security patch level update). |
app/assets/javascripts/application.js.coffee |
Updates Sprockets directive to load the new vendored Bootstrap asset. |
.github/workflows/ci.yml |
Adjusts bundle-audit step error-handling behavior in CI. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
69
to
72
| - name: Bundle Audit | ||
| run: | | ||
| bundle exec bundle-audit update | ||
| bundle exec bundle-audit check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…, CVE-2018-14042, CVE-2019-8331) unpatched; bundle-audit non-blocking in CI