Repository navigation
More RRFS/REFS updates - #558
Merged
Merged
Conversation
Owner
|
Thanks! I'll wait to merge until you tell me it's good to go. |
Contributor
Author
Contributor
Author
|
Ok, I dropped the prototype I'm going to try to update the RRFS gallery example because it won't run, and hopefully add a short REFS example. |
Contributor
Author
|
It looks like the ififp, natlev, and testbed products don't exist anymore, so I removed those. |
Contributor
Author
|
Ok, @blaylockbk, I think this is ready. I added several FastHerbie timeseries examples in the RRFS example gallery notebook. It takes about 8 minutes total to run on my old laptop. Let me know if you think that's too much for the gallery and I can trim it down. |
blaylockbk
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Addresses items in #557:
ensprodto AWS urlfxx=0to1and issues a warningIt would also be really helpful to update the RRFS example gallery https://github.com/blaylockbk/Herbie/blob/main/docs/gallery/noaa_models/rrfs.ipynb (https://herbie.readthedocs.io/en/stable/gallery/noaa_models/rrfs.html) and add something similar for REFS. Maybe that will be a future PR...
@freemansw1, don't want to step on your toes, but I was itching to explore RRFS and ended up with a something that worked. I can close this if you already have something, or you can submit suggestions/edits here.
@blaylockbk, let's give this at least a few days before merging (assuming it works 😅).
Edit # 1: Oh, I think I need to expand the tests...