Update treeffuser.py#116
Open
velezbeltran wants to merge 1 commit into
Open
Conversation
I think this user behavior is probably a better default. Asif got flustered it didn't output anything (+ he didn't know when it was gonna finish). Separately, should we include something in the README that says users shouldn't hesitate about asking for help?
ANazaret
approved these changes
Dec 3, 2024
ANazaret
left a comment
ANazaret
left a comment
Collaborator
There was a problem hiding this comment.
verbose is an int. do we have different levels of verbosity? is it documented?
Collaborator
Author
|
I think it is in the doc string no. If not we should probably document it
further and fix this in pypi asap cause a lot of people will be downloading
it.
Le lun. 2 déc. 2024, 19:34, Achille Nazaret ***@***.***> a
écrit :
… ***@***.**** approved this pull request.
verbose is an int. do we have different levels of verbosity? is it
documented?
—
Reply to this email directly, view it on GitHub
<#116 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AORZQQLJ764URF2VX5KTKWD2DT37TAVCNFSM6AAAAABS3UZDJSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINZUGIYTQOJSGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Collaborator
Author
|
I can take a look at this tomorrow after interviews.
Le lun. 2 déc. 2024, 19:39, Nicolas Beltran ***@***.***> a écrit :
… I think it is in the doc string no. If not we should probably document it
further and fix this in pypi asap cause a lot of people will be downloading
it.
Le lun. 2 déc. 2024, 19:34, Achille Nazaret ***@***.***> a
écrit :
> ***@***.**** approved this pull request.
>
> verbose is an int. do we have different levels of verbosity? is it
> documented?
>
> —
> Reply to this email directly, view it on GitHub
> <#116 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AORZQQLJ764URF2VX5KTKWD2DT37TAVCNFSM6AAAAABS3UZDJSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINZUGIYTQOJSGI>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this user behavior is probably a better default. Asif got flustered it didn't output anything (+ he didn't know when it was gonna finish).
Separately, should we include something in the README that says users shouldn't hesitate about asking for help?