Add Customizable timers, notification display time and corner icon - #180
Open
JoeSchubert wants to merge 4 commits into
Open
Add Customizable timers, notification display time and corner icon#180JoeSchubert wants to merge 4 commits into
JoeSchubert wants to merge 4 commits into
Conversation
- Added static list to track active EventNotification objects - Introduced ClearAll() to properly dispose existing notifications before spawning new ones - Ensured proper memory management and garbage collection by hooking DisposeControl()
- Migrated global notification settings from the Events tab to the BasicSettingsView - Replaced the hard-to-use TrackBar with a TextBox for exact notification duration - Added integer validation for the duration text box
- Introduced LastFiredAlertThreshold to replace boolean HasAlerted flag, preventing duplicate alerts for the same time threshold - Implemented logic to fetch and parse custom time strings on a per-event basis - Merged module default thresholds, JSON-provided event reminders, and user-provided custom times into a unified HashSet to ensure all necessary alerts trigger sequentially
- Added text boxes next to each event in the main Events & Metas tab to allow defining custom reminder times - Pinned text box UI locations to prevent layout engine overlapping - Replaced hardcoded Corner Icon texture with native Watch (eye) texture - Refactored Corner Icon logic to dynamically create and dispose itself when toggled, freeing up Blish HUD UI slots - Fixed context menu left/right click behaviors to strictly display upcoming tracked events - Bumped manifest version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion Reference
I am unsure where to discuss on discord to provide a discord link per the example as I do not see a Contributing.md or anything similar. However, this discussion is covered by the changes in this PR:
#163
Is this a breaking change?
Breaking changes require additional review prior to merging. If you answer yes, please explain what breaking changes have been made.
No
This PR adds the following:
I've done basic testing and everything seems to work as intended.