fix(desktop): harden e2e scroll and persona menu checks#1416
Open
wesbillman wants to merge 1 commit into
Open
Conversation
Treat timeline prepends as a distinct message delta so older-history pages do not look like new unread arrivals when the newest row is unchanged. Also use a fresh Radix menu item lookup for persona provider selections in the e2e test. Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
wesbillman
force-pushed
the
pinky/e2e-scroll-contract
branch
from
6e9119b to
5deaeb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useAnchoredScrollso older history does not increment the new-message affordanceValidation
cd desktop && pnpm buildcd desktop && node --import ./test-loader.mjs --experimental-strip-types --test src/features/messages/lib/timelineSnapshot.test.mjscd desktop && pnpm exec playwright test --project=smoke tests/e2e/scroll-history.spec.ts -g "older-history prepend keeps" --repeat-each=10cd desktop && pnpm exec playwright test --project=integration tests/e2e/persona-env-vars.spec.tsNote: while checking wider scroll coverage,
scroll-history.spec.ts >> does not teleport upward when user abandons fetch by jumping to bottomalso fails on unmodifiedorigin/mainlocally, so I did not fold a speculative fix for that separate existing issue into this PR.