Skip to content

add caching in hashTreeRoot #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gballet merged 5 commits into from
Jun 3, 2026
Merged

add caching in hashTreeRoot #62

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
43e43d0
add caching in hashTreeRoot
anshalshukla Apr 28, 2026
8f748ec
merge master
anshalshukla Jun 1, 2026
7b4ef08
address comments, add make max, min checks comptime
anshalshukla Jun 1, 2026
3293fb6
merge master
anshalshukla Jun 1, 2026
648966f
Apply suggestions from code review
gballet Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions src/lib.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const Allocator = std.mem.Allocator;
const Sha256 = std.crypto.hash.sha2.Sha256;

/// Number of bytes per chunk.
const BYTES_PER_CHUNK = 32;
pub const BYTES_PER_CHUNK = 32;

pub fn serializedFixedSize(T: type) !usize {
const info = @typeInfo(T);
Expand Down Expand Up @@ -417,17 +417,13 @@ pub fn deserialize(T: type, serialized: []const u8, out: *T, allocator: ?Allocat
const enforce_min = !has_custom_decode or comptime std.meta.hasFn(T, "minInLength");
const enforce_max = !has_custom_decode or comptime std.meta.hasFn(T, "maxInLength");

// Bounds check: ensure serialized length is within [minInLength, maxInLength]
const min_len: ?usize = if (enforce_min) blk: {
const m = minInLength(T) catch break :blk null;
break :blk m;
} else null;
// Bounds check: ensure serialized length is within [minInLength, maxInLength].
// The bounds depend only on T, so fold them to comptime constants; types
// with no static bound (e.g. a slice) resolve to null and skip the check.
Comment thread
gballet marked this conversation as resolved.
Outdated
const min_len: ?usize = comptime if (enforce_min) (minInLength(T) catch null) else null;
if (min_len) |m| if (serialized.len < m) return error.PayloadTooSmall;

const max_len: ?usize = if (enforce_max) blk: {
const m = maxInLength(T) catch break :blk null;
break :blk m;
} else null;
const max_len: ?usize = comptime if (enforce_max) (maxInLength(T) catch null) else null;
Comment on lines +421 to +424

@anshalshukla anshalshukla Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to cache min and max length because they have been made comptime and deserialize functions called for types whose size can be calculated will be predetermined and added to binary itself

if (max_len) |m| if (serialized.len > m) return error.PayloadTooLarge;

// shortcut if the type implements its own decode method
Expand Down Expand Up @@ -734,8 +730,8 @@ pub fn chunkCount(T: type) usize {
}
}

const chunk = [BYTES_PER_CHUNK]u8;
const zero_chunk: chunk = [_]u8{0} ** BYTES_PER_CHUNK;
pub const chunk = [BYTES_PER_CHUNK]u8;
pub const zero_chunk: chunk = [_]u8{0} ** BYTES_PER_CHUNK;

pub fn pack(T: type, values: T, l: *ArrayList(u8), allocator: Allocator) ![]chunk {
try serialize(T, values, l, allocator);
Expand Down
Loading
Loading