Repository navigation
ENH: Add min_timeshift support to make_forecasting_frame #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nils-braun
merged 4 commits into
blue-yonder:main
from
Lulloooo:fix-min-timeshift-forecasting-frame
May 31, 2026
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d443b3f
Add min_timeshift support to make_forecasting_frame
Lulloooo 21510c1
Improve test_make_forecasting_frame_ min_timeshift tests in test_datf…
Lulloooo 0261eb0
Updated make_forecasting_frame in dataframe_functions
Lulloooo 8b18d1e
Merge branch 'main' into fix-min-timeshift-forecasting-frame
nils-braun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,6 +47,7 @@ docs/text/_generated/ | |
|
|
||
| # Virtual environment | ||
| venv* | ||
| .venv/ | ||
| activate | ||
|
|
||
| # IPython notebooks | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -1468,6 +1468,30 @@ def test_make_forecasting_frame_feature_extraction(self): | |||||
| default_fc_parameters=MinimalFCParameters(), | ||||||
| ) | ||||||
|
|
||||||
| def test_make_forecasting_frame_min_timeshift(self): | ||||||
| x = pd.Series([1, 2, 3, 4, 5]) | ||||||
| # Default behavior | ||||||
| df_default, y_default = dataframe_functions.make_forecasting_frame( | ||||||
| x=x, | ||||||
| kind="test", | ||||||
| max_timeshift=3, | ||||||
| rolling_direction=1, | ||||||
| ) | ||||||
| # With min_timeshift | ||||||
| df_filtered, y_filtered = dataframe_functions.make_forecasting_frame( | ||||||
| x=x, | ||||||
| kind="test", | ||||||
| max_timeshift=3, | ||||||
| rolling_direction=1, | ||||||
| min_timeshift=2, | ||||||
| ) | ||||||
| # Check fewer rows (core behavior) | ||||||
| assert len(df_filtered) < len(df_default) | ||||||
| # Check target is aligned | ||||||
| assert len(y_filtered) == len(df_filtered.groupby("id").size()) | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. isn't this the same as:
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Implemented your suggestion in the last commit. |
||||||
| # assert in filtered_df each "time" >= 2 | ||||||
| assert all(df_filtered["time"] >= 2) | ||||||
|
|
||||||
|
|
||||||
| class GetIDsTestCase(TestCase): | ||||||
| def test_get_id__correct_DataFrame(self): | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you know the data, it might be better to check the actual len
But using the default df & y, you can check whether the two equal on the intersection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a more robust test in the latest commit, comparing the intersection between default and filtered outputs as suggested. Thanks for the review!