Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integer samples retain their dtype through
extract_features, so energy calculations can overflow before returning a floating result. For example:Promote integer and Boolean inputs to float64 before squaring or taking the dot product in
abs_energy,root_mean_squareandenergy_ratio_by_chunks. Chunk ratios have the same problem: the numerator uses a floating exponent but the denominator currently squares in the integer dtype. Floating input dtypes and unrelated calculators are preserved.Regression checks cover signed and unsigned integers from 8 to 64 bits, Boolean arrays/Series, uneven chunk partitions, and native extraction. The full suite passes (321 passed, 14 skipped). Changed-file hooks pass; all-file hooks reproduce one existing README whitespace violation on unchanged main.
Additional checks load speech and music into 8/16/24/32-bit PCM WAVs and extract 192 windows through serial and multiprocessing paths. Independent Python-integer sums of squares identify 926 wrong feature values before the change and none after it. All 384 floating-input windows and six unrelated features across 576 rows remain byte-identical. This checks arithmetic and extraction behavior, not classification quality. Integer inputs require a float64 work array; full-width integer energy remains a floating approximation.