Skip to content

Fix bug in JsString ends_with#5391

Merged
hansl merged 1 commit into
boa-dev:mainfrom
nekevss:fix-js-string-ends-with
Jun 2, 2026
Merged

Fix bug in JsString ends_with#5391
hansl merged 1 commit into
boa-dev:mainfrom
nekevss:fix-js-string-ends-with

Conversation

@nekevss
Copy link
Copy Markdown
Member

@nekevss nekevss commented Jun 1, 2026

This PR closes #5390

Looks like we're calling the wrong method in ends_with. Fixes the issue and adds a basic test for starts_with and ends_with

@nekevss nekevss requested a review from a team as a code owner June 1, 2026 02:38
@github-actions github-actions Bot added Waiting On Review Waiting on reviews from the maintainers C-Tests Issues and PRs related to the tests. labels Jun 1, 2026
@github-actions github-actions Bot added this to the v1.0.0 milestone Jun 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

Test262 conformance changes

Test result main count PR count difference
Total 53,125 53,125 0
Passed 51,072 51,072 0
Ignored 1,482 1,482 0
Failed 571 571 0
Panics 0 0 0
Conformance 96.14% 96.14% 0.00%

Tested main commit: 85272bf9c8d17c2609aaeb06f3dee88e7f865e77
Tested PR commit: 28aeba4b0a4bbdc6a03cda44144fdfde007eaf14
Compare commits: 85272bf...28aeba4

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.16%. Comparing base (6ddc2b4) to head (28aeba4).
⚠️ Report is 973 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5391       +/-   ##
===========================================
+ Coverage   47.24%   60.16%   +12.91%     
===========================================
  Files         476      566       +90     
  Lines       46892    63030    +16138     
===========================================
+ Hits        22154    37921    +15767     
- Misses      24738    25109      +371     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hansl
Copy link
Copy Markdown
Contributor

hansl commented Jun 2, 2026

No test262 changes, uh.

@hansl hansl added this pull request to the merge queue Jun 2, 2026
Merged via the queue into boa-dev:main with commit aa72ad2 Jun 2, 2026
22 checks passed
@github-actions github-actions Bot removed the Waiting On Review Waiting on reviews from the maintainers label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Tests Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate string ends_with() calling starts_with().

2 participants