chore: enable strict index checks#582
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: b232f01 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
43081j
force-pushed
the
jg/strict-indexing
branch
from
79a19f5 to
fbfa763
Compare
commit: |
This catches a couple of bugs where we were assuming arrays were non empty, for example. By forcing us to check the result of index access, we'll generally catch these bugs.
43081j
force-pushed
the
jg/strict-indexing
branch
from
fbfa763 to
b232f01
Compare
dreyfus92
approved these changes
Jul 3, 2026
Member
|
based |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This catches a couple of bugs where we were assuming arrays were non empty, for example. By forcing us to check the result of index access, we'll generally catch these bugs.
Type of change
Checklist
pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure