Show updates for local package sources - #2628
Merged
Merged
Conversation
Local package sources would show no updates, because they were queried with the packageid: search qualifier that local feeds treat as a plain substring match rather than an exact lookup. They are now queried by id and matched exactly, so their available updates appear. Both local and remote sources also apply the version range, so only packages with a version newer than the installed one are returned. Closes bonsai-rx#2565
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package manager Updates tab would not list updates for local package sources, even though the same packages appear as available updates under the Browse and Installed tabs.
GetUpdatesAsyncqueried each installed package with thepackageid:search qualifier, which the remote V3 search service parses but a local folder source does not.LocalPackageSearchResourcetreats the whole term as a plain substring match, so nothing matched. Local sources are now queried with the raw package id and matched exactly, so their updates appear.The version range argument was also computed but never applied, so the query would return the latest version of every installed package regardless of whether it was newer than the installed one. This was masked by the local-source bug. Because the local
packageid:query returned nothing, neither the Updates tab nor the startup check for available updates ever over-reported for a local source. Fixing the local query would unmask that over-reporting, so the version range is now applied in both the local and remote branches, and only packages with a version newer than the installed one are returned. The Uninstall tab passes an all-inclusive range and is unaffected.Verification
Closes #2565