You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
VideoOut: every video_out_flip test segfaults on macOS reading argv after the main stack moved; fix branch ready #14372
runTests+56 is movq 0x8(%r14), %r15, which loads argv[1].
What was checked
On macOS, main in Flip.cpp saves argc and argv in statics and starts the guest with Aps5StartGuest_nid_no_patch. Since #12126, Aps5StartGuest_nid_no_patch moves the main thread's stack out of the guest arena when the two overlap, as they do on macOS 27. It then frees the old stack. argv lives on that stack. MoveHostStack copies it for *_NSGetArgv(), but the test still reads its saved pointer. GuestMainStackMove.cpp reads *_NSGetArgv() after the move instead.
Under ctest, all 27 entries report skipped, no display or Vulkan device, because ctest runs them with SDL_VIDEODRIVER=offscreen or dummy and SDL's offscreen driver has no Vulkan on macOS.
Run directly with SDL's Cocoa driver and each test's own environment from its ctest definition, all 26 modes pass (VideoOut flip tests passed).
I'll open it as a pull request once #11119 is merged, since the open-PR limit applies until then.
Hi @Betr0x, now that #11119 has merged (Nov 8), are you still planning to open the PR from your fix branch for this? Happy to help test or review it. If you'd rather hand it off, just let me know and I can pick it up, keeping you credited as co-author.
Activity
Jawschamp commentedon Nov 10, 2026
Hi @Betr0x, now that #11119 has merged (Nov 8), are you still planning to open the PR from your fix branch for this? Happy to help test or review it. If you'd rather hand it off, just let me know and I can pick it up, keeping you credited as co-author.