Repository navigation
docs(debt): note the result structure a title passes to sceSaveDataDirNameSearch2 - #10095
Conversation
…rNameSearch2 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
MarcZX10
left a comment
There was a problem hiding this comment.
The documentation change is evidence-bounded and internally consistent. The call site supports the observed result buffer size/layout and count-field use; the entry explicitly says the condition structure was not read and leaves console-specific differences unknown. I checked PR #7780’s same-file change: it adds a separate pending-declarations section, with no line-level overlap in this functional entry. #7780 currently conflicts with main, so combined landing order cannot be confirmed until that PR is refreshed; I do not see a substantive dependency between these two specific edits. In this PR worktree, python3 tools/check_conventions.py --base upstream/main, git diff --check upstream/main...HEAD, and python3 tools/check_main_sync.py all passed (1 ahead/115 behind; merge clean). Hosted eligibility, intake, conventions, and labels checks pass; product build jobs are skipped for this docs-only PR.
|
Checked the entry against the result structure in |
What
The changed entry now reads:
Changed:
docs/dev/debt/libSceSaveData.native.md. No code change.Method: Ghidra 12.1.4 headless on the unwrapped executable of the title named; the addresses are the call sites in that executable as Ghidra maps it, read from the instruction listing (static reading only, nothing run on a console). The listing and decompiled code are game code and are not attached.
Fixes: #10094
Tested
Documentation only.
tools/check_conventions.py --base upstream/mainpasses;git merge-treeagainstmainis clean. Every number in the sentence was recounted against the instruction listing. Not built, not run, no title run.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)AI-assisted (Claude Code).
🤖 Generated with Claude Code